Skip to content
GitLab

Adds not to CodegenComposedSchemas and uses it in python-experimental

Merged Administrator requested to merge github/fork/spacether/feat_adds_not into master

Created by: spacether

Adds not to CodegenComposedSchemas and uses it in python-experimental Note: for the AnyTypeNotString component schema that I made, even though it has not defined, swagger-parser parses it as a Schema rather than a ComposedSchema instance, so I needed to add code checking if not was present when setting composed schema data in the Java layer.

The not feature is used in python-epxerimental in: modules/openapi-generator/src/main/resources/python-experimental/schemas.handlebars and a verification test was added in test_AnyTypeNotString.

This PR also adds composition keywords to SchemaSupportFeatures so users can better tell if a keyword is supported.

  • allOf
  • anyOf
  • oneOf
  • not

Multiple people are confused about what our tooling supports so adding these keywords as supported schema features will help them:

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.