Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !12152

[dart] fixed nullable issue for query parameters in dart generator

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/claudius-kienle/master into master 3 years ago
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: claudius-kienle

Desired Behaviour

The dart generator should only append the query parameter to the request if it is not required and nullable (like addressed in #8837). A possible openapi configuration snippet would be the following:

"/api/v1/specific_endpoint/": {
      "get": {
        "parameters": [
          {
            "in": "query",
            "name": "specific_parameter",
            "required": false,
            "schema": {
              "type": "integer",
              "default": null,
              "nullable": true
            }
          }
        ],

Current Behaviour

The generator always adds the query parameter to the request map, even if it is nullable and not required.

Change

When investigating the respective template, I found that the generator would add the nullable check only, if the query parameter is not nullable. Therefore, I changed this so that the generator now adds the nullable check, if the query parameter is not required but nullable.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Checking approval status

Closed by (Jul 27, 2025 8:24am UTC)

Loading

Activity


  • Administrator closed 3 years ago

    closed

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: OpenAPITools/openapi-generator!12152
Source branch: github/fork/claudius-kienle/master

Menu

Explore Projects Groups Snippets