Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !12198

Adds ability to turn inline model resolver on or off and uses it in python-experimental

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/spacether/feat_add_inline_model_resolver_cli_option into master Apr 21, 2022
  • Overview 0
  • Commits 10
  • Pipelines 0
  • Changes 224

Created by: spacether

Adds getUseInlineModelResolver and uses it python-experimental defaults inline model resolver to off, which allows inline schemas at any location

Reason for this change:

Many issues have been filed because our tooling's handling of inline schemas does not always work. With this generator I am seeking to show that code can be generated that supports inline schemas of any depth at any location. Turning inline model resolver off demonstrates that. The inline model resolver looks for complex inline schemas and extracts them into component schemas, replacing the original schema with a $ref to the new component schema.

Breaking change with fallback

This is a breaking change if users are depending upon the schemas that the inline model resolver extracts to exist as separate models. To return to the past behavior, pass in useInlineModelResolver=true when generating the client Note: because the python-experimental generator is experimental status, breaking changes are allowed in non-major releases too.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/spacether/feat_add_inline_model_resolver_cli_option