Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !12345

[java][okhttp-gson] Remove errorObjectType as it's not used

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged William Cheng requested to merge java-okhttp-remove-error-type into master 3 years ago
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Remove errorObjectType as it's not used

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

Compare
  • master (base)

and
  • latest version
    29a9f613
    1 commit, 2 years ago

2 files
+ 0
- 21

    Preferences

    File browser
    Compare changes
modules/…/…/…/…‎/…/…/okhttp-gson‎
api.mu‎stache‎ +0 -2
apiExcepti‎on.mustache‎ +0 -19
modules/openapi-generator/src/main/resources/Java/libraries/okhttp-gson/api.mustache
+ 0
- 2
  • View file @ 29a9f613

  • Edit in single-file editor

  • Open in Web IDE


@@ -333,7 +333,6 @@ public class {{classname}} {
return localVarApiClient.executeStream(localVarCall, localVarReturnType);
} catch (ApiException e) {
e.setErrorObject(localVarApiClient.getJSON().getGson().fromJson(e.getResponseBody(), new TypeToken<{{{errorObjectType}}}>(){}.getType()));
e.setErrorObjectType(new GenericType<{{{errorObjectType}}}>(){});
throw e;
}
{{/errorObjectType}}
@@ -355,7 +354,6 @@ public class {{classname}} {
return localVarApiClient.execute(localVarCall, localVarReturnType);
} catch (ApiException e) {
e.setErrorObject(localVarApiClient.getJSON().getGson().fromJson(e.getResponseBody(), new TypeToken<{{{errorObjectType}}}>(){}.getType()));
e.setErrorObjectType(new GenericType<{{{errorObjectType}}}>(){});
throw e;
}
{{/errorObjectType}}
modules/openapi-generator/src/main/resources/Java/libraries/okhttp-gson/apiException.mustache
+ 0
- 19
  • View file @ 29a9f613

  • Edit in single-file editor

  • Open in Web IDE


@@ -22,7 +22,6 @@ public class ApiException extends{{#useRuntimeException}} RuntimeException {{/us
private String responseBody = null;
{{#errorObjectType}}
private {{{errorObjectType}}} errorObject = null;
private GenericType errorObjectType = null;
{{/errorObjectType}}
/**
@@ -174,24 +173,6 @@ public class ApiException extends{{#useRuntimeException}} RuntimeException {{/us
}
{{#errorObjectType}}
/**
* Get the error object type.
*
* @return Error object type
*/
public GenericType getErrorObjectType() {
return errorObjectType;
}
/**
* Set the error object type.
*
* @param errorObjectType object type
*/
public void setErrorObjectType(GenericType errorObjectType) {
this.errorObjectType = errorObjectType;
}
/**
* Get the error object.
*
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
Client: Java Enhancement: Code Cleanup
2
Client: Java Enhancement: Code Cleanup
    Assign labels
  • Manage project labels

Milestone
6.0.0
6.0.0 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
William Cheng
Reference: OpenAPITools/openapi-generator!12345
Source branch: java-okhttp-remove-error-type

Menu

Explore Projects Groups Snippets