Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !12419

[Rust] Adds UUID support from 'uuid' crate for better compile-time checks

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/taufik-rama/rust-uuid-crate into master May 21, 2022
  • Overview 0
  • Commits 4
  • Pipelines 0
  • Changes 47

Created by: taufik-rama

Hello 👋

I've some changes regarding Rust codegen. Currently I uses UUID for one of the value, and I think it would be nice if we can get this functionality merged, since uuid crate support should already be pretty stable (it's already 1.0), and it provides better compile-time check than plain String value

I base this changes from my previous PR on #12409 since it fixes the bug on UUID handling, which is needed here

I don't have much experience on current Java/Mustache codebase 😅, so any review/feedback is appreciated

Before

// Single parameter
#[derive(Clone, Debug, Default)]
pub struct UsersDeleteParams {
    pub id: Option<String>,
    // ...
}

// Multi parameter
pub async fn users_delete(configuration: &configuration::Configuration, id: Option<&str> /* ... */ ) { /* ... */ }

After

// Single parameter
#[derive(Clone, Debug, Default)]
pub struct UsersDeleteParams {
    pub id: Option<Uuid>,
    // ...
}

// Multi parameter
pub async fn users_delete(configuration: &configuration::Configuration, id: Option<Uuid> /* ... */ ) { /* ... */ }

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @paladinzh
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/taufik-rama/rust-uuid-crate