Skip to content
GitLab

[Gradle] Modernize Gradle plugin build configuration by moving to Gradle-7.4.2 and Kotlin DSL

Open Administrator requested to merge github/fork/saschpe/gradle-modernize into master

Created by: saschpe

The Gradle version currently in use is very (very) outdated and does not work with Java 12 or later, thus making it hard to contribute to the project. The OpenAPI Generator Gradle plugin already uses Kotlin code and interacts with Gradle's Kotlin DSL. Therefore, porting the project configuration itself to Gradle Kotlin DSL simplifies project configuration. It also provides better IntelliJ hinting and built-time type-safety.

Breaking Changes

I took the liberty and got rid of the Sonatype Gradle plugin. Publishing to OSS SonaType can be done entirely with the bundled maven-publish Gradle. Continuous SNAPSHOT version publishing to any repository (~/.m2/repository or remote) is very much a Maven thing. Developers can ./gradlew publishToMavenLocal directly when improving on the generator or it's Gradle plugin.

However, the close and release steps on SonaType are now manual tasks. Thus, a new release needs a person to do this final step. If this isn't an option, I could look into bringing back the old behavior as well.

Other remarks

I kept the Kotlin code cleanup in the plugin itself separate from the build configuration changes and could submit another MR. Those changes could probably get merged faster.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.0.1) (patch release), 6.1.x (breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.