Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !12780

[PHP] Fix message for InvalidArgumentException(), when failing to test pattern

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/thomasphansen/th_bugfix_php_model_generic_mustache_value_instead_of_variable_name into master Jul 06, 2022
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: thomasphansen

model_generic.mustache: Display property name instead of its value, when throwing InvalidArgumentException() for values not respecting a given pattern.

This is an old annoying bug: in 2016 the error message for this InvalidArgumentException() mas changed from single to double quotes, to allow patterns containing single quotes. This caused the "$" sign (plus the following property name) to be parsed, making the error message display its content, instead of its name (like in all other exception messages in this file). This PR fixes that by escaping the "$" sign.

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ybelenko, @renepardon
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/thomasphansen/th_bugfix_php_model_generic_mustache_value_instead_of_variable_name