Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !12848
An error occurred while fetching the assigned milestone of the selected merge_request.

Aspnetcore Generator - New pocoModels parameter for POCO models

  • Review changes

  • Download
  • Email patches
  • Plain diff
Administrator requested to merge github/fork/knom/aspnetcore-poco into master 3 years ago
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 5

Created by: knom

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

FYI: @mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti

Added a new parameter for the C# ASPNETCORE generators. So that you generate POCO Models -- aka. models that don't include IEquatable methods and the operators. This is highly appreciated by some DEVs, who like to use slim POCO classes - and not have the extra methods and operators there.

Approval is optional

Merge details

  • 2 commits and 1 merge commit will be added to master.
  • Source branch will not be deleted.

Activity


  • William Cheng
    William Cheng @wing328 · 3 years ago
    Contributor

    Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

    Let me know if you need help fixing it.

    Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

  • William Cheng added Enhancement: Feature label 3 years ago

    added Enhancement: Feature label

  • William Cheng added Server: C-Sharp label 3 years ago

    added Server: C-Sharp label

  • William Cheng
    William Cheng @wing328 · 3 years ago
    Contributor

    Looks good.

  • William Cheng
    William Cheng @wing328 · 3 years ago
    Contributor

    Will try to run some tests and get it merged by this weekend.

  • William Cheng changed milestone to %6.1.0 3 years ago

    changed milestone to %6.1.0

  • William Cheng closed 3 years ago

    closed

  • William Cheng
    William Cheng @wing328 · 3 years ago
    Contributor

    Tested locally and the result is good.

    I've merged http://metis.lti.cs.cmu.edu:8023/OpenAPITools/openapi-generator/-/merge_requests/12900 to add some tests in the CI (Github workflow)

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/knom/aspnetcore-poco

Menu

Explore Projects Groups Snippets