Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !12849

[PHP] ObjectSerializer::deserialize() associative arrays bugfix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/thomasphansen/th_php_object_serializer_deserialize_bugfix into master Jul 13, 2022
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: thomasphansen

This comes from a bug we found while dealing with the Tripletex API.

ObjectSerializer::deserialize()'s last else block instantiates an object of type $class and tries to populate it with the contents of $data. From this point on, $data is always handled as an object, as we check for its properties ($data->{$discriminator} or $data->{$instance::attributeMap()[$property]}.

But while working with Tripletex (and after a lot of debugging), we figured out that in some very specific cases the received $data parameter was an associative array, which then caused all properties from the instance to become empty.

This PR casts $data to object, in case it is an array. It is absolutely harmless, since it happens in the last else block (where we only care for an object anyway). It's only purpose is to make sure that the data in a received associative array will be properly handled as an object.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the [technical committee] @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ybelenko, @renepardon
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/thomasphansen/th_php_object_serializer_deserialize_bugfix