Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !12861

Update allOf to not always be nullable

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged devhl-labs requested to merge github/fork/devhl-labs/generic-host-fixes4-merge-master into master Jul 14, 2022
  • Overview 2
  • Commits 43
  • Pipelines 0
  • Changes 12

This is part of a larger PR that is being broken up. Updates allOf to not always be nullable.

To validate this change, I will focus on AllOfWithSingleRef.cs. Before the change, I edited modelGeneric.mustache to determine what properties were determining the EmitDefaultValue change by adding a /comment/ after the boolean.

...EmitDefaultValue={{#vendorExtensions.x-emit-default-value}}true /*venderExtension*/{{/vendorExtensions.x-emit-default-value}}{{^vendorExtensions.x-emit-default-value}}{{#isNullable}}true /*nullable*/{{/isNullable}}{{^isNullable}}{{#required}}true /*required*/{{/required}}{{^required}}false /*not required*/{{/required}}...

The result is that EmitDefaultValue is being determined by the property always being nullable: image

After the change, we see image

So we see the change makes the allOf neither required nor nullable. The input spec for this sample is modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing.yaml. Below is the definition for this object. It is not nullable in the spec, and it is no longer nullable in code.

image

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/devhl-labs/generic-host-fixes4-merge-master