Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !12910
An error occurred while fetching the assigned milestone of the selected merge_request.

Add support for string response deserialization

  • Review changes

  • Download
  • Email patches
  • Plain diff
Administrator requested to merge github/fork/emajo/master into master 3 years ago
  • Overview 3
  • Commits 9
  • Pipelines 0
  • Changes 123

Created by: emajo

With this change if the response is a string (int and others also) it gets serializated correctly.

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Loading
Loading

Activity


  • William Cheng
    William Cheng @wing328 · 3 years ago
    Contributor

    can you please follow step 3 to update the samples? https://github.com/OpenAPITools/openapi-generator/runs/7391115788?check_suite_focus=true

  • William Cheng added Client: C-Sharp label 3 years ago

    added Client: C-Sharp label

  • William Cheng added Issue: Bug label 3 years ago

    added Issue: Bug label

  • William Cheng changed milestone to %6.1.0 3 years ago

    changed milestone to %6.1.0

  • William Cheng
    William Cheng @wing328 · 3 years ago
    Contributor

    the samples are still not up-to-date. not sure why. I'll update the samples after the PR.

    thanks for the contribution.

  • William Cheng closed 3 years ago

    closed

  • William Cheng mentioned in merge request !12964 (merged) 3 years ago

    mentioned in merge request !12964 (merged)

  • William Cheng
    William Cheng @wing328 · 3 years ago
    Contributor

    FYI. Not sure why the samples are messed up. I've to revert this change and filed http://metis.lti.cs.cmu.edu:8023/OpenAPITools/openapi-generator/-/merge_requests/12964 instead.

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/emajo/master

Menu

Explore Projects Groups Snippets