Skip to content
GitLab

[typescript-axios] avoid stringifying header string values

Merged Administrator requested to merge github/fork/stropho/ts-axios-header-string-value into master

Created by: stropho

Serialization of complex headers was introduced in https://github.com/OpenAPITools/openapi-generator/pull/1874 . However, a header value of type string/enum defined via $ref is serialized as well.

JSON.stringify('foo') === '"foo"' // note the problematic extra quotes

The only (known to me) workaround is to use the last parameter of generated methods: options: AxiosRequestConfig where we can override all headers. A cumbersome solution.

This PR solves the problem of stringifying values that are already string.

Fixes https://github.com/OpenAPITools/openapi-generator/issues/10840

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)