Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !1308

Update python samples and comment out flake8 test

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged William Cheng requested to merge fix_python_build_issue into master 6 years ago
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 12

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

A temporary fix to https://github.com/OpenAPITools/openapi-generator/issues/1307

cc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10)

Compare
  • master (base)

and
  • latest version
    14e8dd8e
    1 commit, 2 years ago

12 files
+ 21
- 18

    Preferences

    File browser
    Compare changes
samples/cli‎ent/petstore‎
pyt‎hon‎
.openapi-‎generator‎
VER‎SION‎ +1 -1
do‎cs‎
Categ‎ory.md‎ +1 -1
petstore_‎api/models‎
categ‎ory.py‎ +4 -3
test_pytho‎n2_and_3.sh‎ +1 -1
python-‎asyncio‎
.openapi-‎generator‎
VER‎SION‎ +1 -1
do‎cs‎
Categ‎ory.md‎ +1 -1
petstore_‎api/models‎
categ‎ory.py‎ +4 -3
test_py‎thon3.sh‎ +1 -1
python-‎tornado‎
.openapi-‎generator‎
VER‎SION‎ +1 -1
do‎cs‎
Categ‎ory.md‎ +1 -1
petstore_‎api/models‎
categ‎ory.py‎ +4 -3
test_pytho‎n2_and_3.sh‎ +1 -1
samples/client/petstore/python/.openapi-generator/VERSION
+ 1
- 1
  • View file @ 14e8dd8e

  • Edit in single-file editor

  • Open in Web IDE

3.3.0-SNAPSHOT
\ No newline at end of file
3.3.2-SNAPSHOT
\ No newline at end of file
samples/client/petstore/python/docs/Category.md
+ 1
- 1
  • View file @ 14e8dd8e

  • Edit in single-file editor

  • Open in Web IDE


@@ -4,7 +4,7 @@
Name | Type | Description | Notes
------------ | ------------- | ------------- | -------------
**id** | **int** | | [optional]
**name** | **str** | | [optional]
**name** | **str** | | [default to 'default-name']
[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)
samples/client/petstore/python/petstore_api/models/category.py
+ 4
- 3
  • View file @ 14e8dd8e

  • Edit in single-file editor

  • Open in Web IDE


@@ -40,7 +40,7 @@ class Category(object):
'name': 'name'
}
def __init__(self, id=None, name=None): # noqa: E501
def __init__(self, id=None, name='default-name'): # noqa: E501
"""Category - a model defined in OpenAPI""" # noqa: E501
self._id = None
@@ -49,8 +49,7 @@ class Category(object):
if id is not None:
self.id = id
if name is not None:
self.name = name
self.name = name
@property
def id(self):
@@ -91,6 +90,8 @@ class Category(object):
:param name: The name of this Category. # noqa: E501
:type: str
"""
if name is None:
raise ValueError("Invalid value for `name`, must not be `None`") # noqa: E501
self._name = name
samples/client/petstore/python/test_python2_and_3.sh
+ 1
- 1
  • View file @ 14e8dd8e

  • Edit in single-file editor

  • Open in Web IDE


@@ -24,7 +24,7 @@ python setup.py develop
tox || exit 1
### static analysis of code
flake8 --show-source petstore_api/
#flake8 --show-source petstore_api/
### deactivate virtualenv
#if [ $DEACTIVE == true ]; then
samples/client/petstore/python-asyncio/.openapi-generator/VERSION
+ 1
- 1
  • View file @ 14e8dd8e

  • Edit in single-file editor

  • Open in Web IDE

3.3.1-SNAPSHOT
\ No newline at end of file
3.3.2-SNAPSHOT
\ No newline at end of file
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
Client: C-Sharp Enhancement: General
2
Client: C-Sharp Enhancement: General
    Assign labels
  • Manage project labels

Milestone
5.3.0
5.3.0 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: OpenAPITools/openapi-generator!10207
Source branch: fix_python_build_issue

Menu

Explore Projects Groups Snippets