Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !13120

Make "applyToParams" a Future + add "this." when decoding JSON

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/noordawod/regression/features into master Aug 06, 2022
  • Overview 11
  • Commits 36
  • Pipelines 0
  • Changes 67

Created by: noordawod

This pr brings back 2 lost "features" that were present earlier (and of course with the proper explanation as to why we need them back), and introduces a couple of new features as well:

  1. Inside a function, private-style variables (var _json) make no sense – so removed the underscore.
  2. The authNames were mysteriously dropped, why? These are important information to each endpoint, and the authentication implementation may need to check which authentications to apply for each operation.
  3. Removed use of the bang operator (!) when activating the authentication implementation – just use what Dart gives us out of the box: authentication?.applyToParams(…)
  4. Converted the applyToParams method to a Future<void>. Custom implementations may need to retrieve data from persistent stores, for example, and so may need this.
  5. Since Authentication is an interface, and in case ApiClient is inherited, one can now declare the generic T extends Authentication class upon extension. Helps to access properties added in the inherited class (yes, this is backward-compatible and Dart, luckily, doesn't scream about it.)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @wing328 @jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/noordawod/regression/features