Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !13193

[rust]: Remove unmaintained samples and specs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/jacob-pro/tidy-rust-samples into master Aug 15, 2022
  • Overview 5
  • Commits 4
  • Pipelines 0
  • Changes 126

Created by: jacob-pro

This removes the unmaintained samples and specs for the Rust client which are no longer automatically built.

The 2 test cases, TypeTesting and fileResponse have been merged into the main Rust spec (modules/openapi-generator/src/test/resources/3_0/rust/petstore.yaml).

See slack thread: https://openapi-generator.slack.com/archives/CLSB0U0R5/p1660567811900359?thread_ts=1660508979.486299&cid=CLSB0U0R5

The rust-reqwest-petstore-async and rust-reqwest-petstore-awsv4signature have also been changed to use the rust specific spec.

I have added a unit test for the TypeTesting case, currently in reqwest/petstore. Of the 4 different samples I am not sure if this is the correct one to put this test in?

An obsevation concerning the fileResponse test, it looks to me like the generated code for file download is completely broken, for both reqwest and hyper, since they are both attempting to deserialize the response as JSON! So this will need to be fixed separately. Edit: already reported here: https://github.com/OpenAPITools/openapi-generator/pull/9021

Another observation is that despite being configured with supportAsync: "false", the hyper client generator is producing asynchronous code (using futures)... Two issues here: Hyper doesn't have a blocking API, so this combination shouldn't be allowed. The generated code should be using the more modern async syntax rather than directly returning Futures

cc: @wing328 @spacether

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jacob-pro/tidy-rust-samples