Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !13260

[typescript-fetch]Fix subtype serialization with discriminators

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Administrator requested to merge github/fork/SimonErm/fix/discriminator-serialization into master 2 years ago
  • Overview 1
  • Commits 7
  • Pipelines 1
  • Changes 118

Created by: SimonErm

Currently the generated typescript-fetch client only handles the decriminator value on deserialization to resolve the correct subtype, but not for serialization. This PR fixes this by adding the same behaviour for serialization

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)
Pipeline #670 failed for b4de0f6a on github/fork/SimonErm/fix/discriminator-serialization 2 years ago
Approval is optional

Ready to merge by members who can write to the target branch.

  • The source branch is 711 commits behind the target branch
  • 7 commits and 1 merge commit will be added to master.
  • Source branch will not be deleted.

Activity


  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: macjohnny

    A general question: why is discriminator handling needed for serialization? Can you give an example input and the actual vs expected output?

  • Administrator restored source branch github/fork/SimonErm/fix/discriminator-serialization 2 years ago

    restored source branch github/fork/SimonErm/fix/discriminator-serialization

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: OpenAPITools/openapi-generator!13260
Source branch: github/fork/SimonErm/fix/discriminator-serialization

Menu

Explore Projects Groups Snippets