Skip to content
GitLab

[python-experimental] Improves additionalProperties processing when additionalProperties is unset

Merged Administrator requested to merge github/fork/spacether/python_exp_add_AnyTypeUnset into master

Created by: spacether

  • Improves additionalProperties processing when additionalProperties is unset
    • when there is no spec schema, a special UnsetAnyTypeSchema is used
    • If any other schema is validated at that location, then UnsetAnyTypeSchema is removed from the final manufactured class
  • This change is needed to be able to implement unevaluatedProperties in the future
    • a schema from unevaluatedProperties would apply for use cases where UnsetAnyTypeSchema is currently being validated.
  • Removes UnsetAnyTypeSchema from known previously validated schemas if an ingested Schema instance contains it as one of its base classes
    • this is needed to ensure correct Schema validations are run for that use case
  • Deletes the code to detect if an instance is already of the right class, that never happens any more. It no longer happens because the code allows instances of Schemas to be passed in, and when they are they are converted back into primitive data and the validations are run again. The ingested Schema class info is preserved and validations are not run again if they don't need to.
  • type hints improved to show that values will be of type UnsetAnyTypeSchema

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.