Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !13397

[fix][python-flask][python-aiohttp]: incorrect boolean literal in unit tests

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Kevin-Bannier/fix/python-flask-incorrect-boolean-literal-unit-tests into master Sep 09, 2022
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: Kevin-Bannier

Fixes #9386 (closed)

When using generators python-flaskand python-aiohttp, the generated test body boolean values reads now as follows ("True" or "False"):

body = {
  "boolean_property": True
}

Previous buggy generated code:

body = {
  "boolean_property": true
}

Most of the code is copy-paste from generator python-fastapi(PythonFastAPIServerCodegen.java)

Steps to see the new generated code:

java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar generate \
   -i modules/openapi-generator/src/test/resources/3_0/petstore.yaml \
   -g python-flask \
   -o /var/tmp/python-flask
cat /var/tmp/python-flask/openapi_server/test/test_store_controller.py

java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar generate \
   -i modules/openapi-generator/src/test/resources/3_0/petstore.yaml \
   -g python-aiohttp \
   -o /var/tmp/python-aiohttp

cat /var/tmp/python-aiohttp/tests/test_store_controller.py

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @arun-nalla @spacether
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Kevin-Bannier/fix/python-flask-incorrect-boolean-literal-unit-tests