Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !13536

The Instance is not a Set, it is a GrowableList, After checking Itera…

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Administrator requested to merge github/fork/cevheri/master into master Sep 27, 2022
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Created by: cevheri

was marked as uniqueItems:true in API-DOC. The Instance is not a Set, it is a GrowableList, After checking Iterable, convert from GrowableList to Set image

Hello there, I created a dart project using openapi-generator. In the api I used, the String Array inside a model was marked as uniqueItems=true. openapi-generator converted it to Set . In the generated code, the Serizalize/Deserialize operations in the fromJson() and toJson() methods in the model were incorrect. I fixed in the code I used first, and then I downloaded the openapi-generator's codes, forked it myself and made the correction there. I wanted to ask if anyone has had this problem before. I have now made the change/tests and will send a PR to Master Branch.

Generated Code:

  • Model Constructure: image
  • Field: image -toJson Method: image
  • fromJson Method: image

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/cevheri/master