Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !13641
An error occurred while fetching the assigned milestone of the selected merge_request.

[csharp] Delete and build samples

  • Review changes

  • Download
  • Email patches
  • Plain diff
devhl-labs requested to merge github/fork/devhl-labs/delete-and-build-samples into master 2 years ago
  • Overview 5
  • Commits 9
  • Pipelines 0
  • Changes 379

Just rebuilding the samples.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Loading
Loading

Activity


  • William Cheng
    William Cheng @wing328 · 2 years ago
    Contributor

    Appveyor CI tests didn't pass despite restarted several times: https://ci.appveyor.com/project/WilliamCheng/openapi-generator/builds/45014214

    Can you please take a look when you've time?

  • William Cheng added Client: C-Sharp Enhancement: CI/Test labels 2 years ago

    added Client: C-Sharp Enhancement: CI/Test labels

  • William Cheng changed milestone to %6.2.1 2 years ago

    changed milestone to %6.2.1

  • devhl-labs
    devhl-labs @devhl-labs · 2 years ago
    Author Contributor

    @wing328 The tests failing also fail for master. @Blackclaws can you take a look? Looks to me like the add pet method should have authentication but there is none. For comparison, the delete pet method does have authentication.

    image image image

  • William Cheng
    William Cheng @wing328 · 2 years ago
    Contributor

    @wing328 The tests failing also fail for master.

    did you run the pestore server locally?

    https://github.com/OpenAPITools/openapi-generator/wiki/Integration-Tests

  • William Cheng
    William Cheng @wing328 · 2 years ago
    Contributor

    appveyor tests passed via https://ci.appveyor.com/project/WilliamCheng/openapi-generator/builds/45081364

  • Administrator
    Administrator @root · 2 years ago
    Contributor

    Merged by: wing328 at 2022-10-16 02:18:49 UTC

  • William Cheng closed 2 years ago

    closed

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
2
2 participants
Nikita Lutsenko
Administrator
Reference:
Source branch: github/fork/devhl-labs/delete-and-build-samples

Menu

Explore Projects Groups Snippets