Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !13655
An error occurred while fetching the assigned milestone of the selected merge_request.

Fix typescript codegen crash on extracting regular expression

  • Review changes

  • Download
  • Email patches
  • Plain diff
Administrator requested to merge github/fork/wingyplus/iss-13390 into master 2 years ago
  • Overview 8
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: wingyplus

Fixes codegen returns error when schema has a pattern property:

Exception: Unbalanced '{' - missing '}' at
'z0-9]{3'

mention the technical committee members @TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka

Fixes #13390 (closed)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Approval is optional

Merge details

  • 3 commits and 1 merge commit will be added to master.
  • Source branch will not be deleted.
  • Mentions issue #13390 (closed)

Activity


  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: danihodovic

    Here is an example of the error

      Exception: Unbalanced '{' - missing '}' at
    '[0-9]{7'
          ^
            at org.openapitools.codegen.DefaultGenerator.processOperation(DefaultGenerator.java:1187)
            at org.openapitools.codegen.DefaultGenerator.processPaths(DefaultGenerator.java:1081)
    

    The code portion that is probably causing the error:

            isrc:
              type: string
              pattern: '[a-zA-Z0-9]{5}[0-9]{7}'
              maxLength: 255
  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: zodiia

    Any updates on this? @wingyplus

  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: zodiia

    Could we please have an update on this? The generator is currently unusable and has been for at least the last three months (since I first reported the issue). @wingyplus @macjohnny

  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: bodograumann

    Seems the author does not respond. Are you able to create a PR yourself, @zodiia ? If not, I could probably do it. Imho we should get rid of the option to have / delimiters in the patterns as it is non-standard.

  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: zodiia

    Seems the author does not respond. Are you able to create a PR yourself, @zodiia ? If not, I could probably do it. Imho we should get rid of the option to have / delimiters in the patterns as it is non-standard.

    I'm taking a look at this, I will keep you updated ASAP.

  • Administrator mentioned in merge request !14180 (merged) 2 years ago

    mentioned in merge request !14180 (merged)

  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: zodiia

    @bodograumann I just opened a new PR. This one should probably be closed.

  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: danihodovic

    @zodiia I ran into the same issue and gave up on this client. Instead I'm using python-prior which works fine.

  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: macjohnny

    Closing in favor of http://metis.lti.cs.cmu.edu:8023/OpenAPITools/openapi-generator/-/merge_requests/14180

  • Administrator closed 2 years ago

    closed

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/wingyplus/iss-13390

Menu

Explore Projects Groups Snippets