Skip to content
GitLab

[jaxrs-cxf-cdi] use jackson for enum serialization

Merged Administrator requested to merge github/fork/selliera/cxf-cdi-json-enum into master

Created by: selliera

When using jaxrs-cxf-cdi, contrary to the other cxf generators, the enums are not setup with the json serializer so that the value in the openapi is the one that gets serialized.

It looks like there is simply a missing jackson annotation on the enum, that will make it work. An alternative option is to configure the jackson serializer in the application, to use SerializationFeature.WRITE_ENUMS_USING_TO_STRING and DeserializationFeature READ_ENUMS_USING_TO_STRING But this approach:

  • requires a special configuration of the mapper
  • is inconsistent with other generators
  • imposes a configuration that has effects for the other usages of jackson in a application

PR checklist

  • [x ] Read the contribution guidelines.
  • [x ] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x ] Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

java technical commitee @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)