Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !13773

[elm] add function to allow more fine grained error handling

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/7omb/generalize-elm-error-handling into master 2 years ago
  • Overview 7
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: 7omb

This is a backwards compatible change. It adds the additional function sendWithCustomExpect to the provided helper functions in Api.elm to make requests.

It can be used to implement a more fine grained error handling as described here. Before it was e.g. not possible to access the response body if the server responded with an error like 404.

@eriktim

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Compare
  • master (base)

and
  • latest version
    40e310b8
    1 commit, 2 years ago

2 files
+ 16
- 4

    Preferences

    File browser
    Compare changes
modules/openapi-g‎enerator/…/…/…/elm‎
Api.mu‎stache‎ +8 -2
samples/openapi‎3/client/elm/src‎
Api‎.elm‎ +8 -2
modules/openapi-generator/src/main/resources/elm/Api.mustache
+ 8
- 2
  • View file @ 40e310b8

  • Edit in single-file editor

  • Open in Web IDE


@@ -3,6 +3,7 @@ module Api exposing
, request
, send
, sendWithCustomError
, sendWithCustomExpect
, task
, map
, withBasePath
@@ -55,13 +56,18 @@ send toMsg req =
sendWithCustomError : (Http.Error -> e) -> (Result e a -> msg) -> Request a -> Cmd msg
sendWithCustomError mapError toMsg (Request req) =
sendWithCustomError mapError toMsg req =
sendWithCustomExpect (expectJson mapError toMsg) req
sendWithCustomExpect : (Json.Decode.Decoder a -> Http.Expect msg) -> Request a -> Cmd msg
sendWithCustomExpect expect (Request req) =
Http.request
{ method = req.method
, headers = req.headers
, url = Url.Builder.crossOrigin req.basePath req.pathParams req.queryParams
, body = req.body
, expect = expectJson mapError toMsg req.decoder
, expect = expect req.decoder
, timeout = req.timeout
, tracker = req.tracker
}
samples/openapi3/client/elm/src/Api.elm
+ 8
- 2
  • View file @ 40e310b8

  • Edit in single-file editor

  • Open in Web IDE


@@ -3,6 +3,7 @@ module Api exposing
, request
, send
, sendWithCustomError
, sendWithCustomExpect
, task
, map
, withBasePath
@@ -55,13 +56,18 @@ send toMsg req =
sendWithCustomError : (Http.Error -> e) -> (Result e a -> msg) -> Request a -> Cmd msg
sendWithCustomError mapError toMsg (Request req) =
sendWithCustomError mapError toMsg req =
sendWithCustomExpect (expectJson mapError toMsg) req
sendWithCustomExpect : (Json.Decode.Decoder a -> Http.Expect msg) -> Request a -> Cmd msg
sendWithCustomExpect expect (Request req) =
Http.request
{ method = req.method
, headers = req.headers
, url = Url.Builder.crossOrigin req.basePath req.pathParams req.queryParams
, body = req.body
, expect = expectJson mapError toMsg req.decoder
, expect = expect req.decoder
, timeout = req.timeout
, tracker = req.tracker
}
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
6.2.1
6.2.1 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
2
2 participants
Administrator
William Cheng
Reference: OpenAPITools/openapi-generator!13773
Source branch: github/fork/7omb/generalize-elm-error-handling

Menu

Explore Projects Groups Snippets