Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !13802

fix #13150 Add uniqueModelMappings option

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed bernie-schelberg-mywave requested to merge github/fork/bernie-schelberg-mywave/issue13150 into master 2 years ago
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 4

Having multiple names for a model mapping can cause issues with clients that are expecting a particular types to always have the same model name. Refer https://github.com/OpenAPITools/openapi-generator/issues/13150. Since this potentially breaks system that rely on having the class names work as mappings alongside custom discriminator values, a new configuration option has been added - uniqueModelMappings (defaults to false).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Approval is optional

Closed by bernie-schelberg-mywavebernie-schelberg-mywave 2 years ago (Oct 30, 2022 10:19pm UTC) 2 years ago

Merge details

  • The changes were not merged into master.
  • Mentions issue #13150

Activity


  • Administrator
    Administrator @root · 2 years ago
    Contributor

    Created by: arandth

    Review: Commented

    To be honost: I don't see why we should need a new option for this. If this behavior is considered to be a bug, then it should be corrected without the need to set an new option.

  • bernie-schelberg-mywave
    bernie-schelberg-mywave @bernie-schelberg-mywave · 2 years ago
    Author

    @arandth I'm happy to submit another that just fixes the issue, and doesn't add a new option, please advise if this is preferred.

  • bernie-schelberg-mywave
    bernie-schelberg-mywave @bernie-schelberg-mywave · 2 years ago
    Author

    I opened another pull request which treats this issue as a bug and doesn't add the new configuration option: http://metis.lti.cs.cmu.edu:8023/OpenAPITools/openapi-generator/-/merge_requests/13815. I'm happy to close this one if the other is preferred.

  • bernie-schelberg-mywave mentioned in issue #13150 2 years ago

    mentioned in issue #13150

  • bernie-schelberg-mywave
    bernie-schelberg-mywave @bernie-schelberg-mywave · 2 years ago
    Author

    Closing this one as the consensus seems to be that this is indeed a bug, and doesn't need another option to enable or disable the behaviour. Refer to #13815

  • bernie-schelberg-mywave closed 2 years ago

    closed

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
2
2 participants
Administrator
bernie-schelberg-mywave
Reference: OpenAPITools/openapi-generator!13802
Source branch: github/fork/bernie-schelberg-mywave/issue13150

Menu

Explore Projects Groups Snippets