Created by: Digirik
This PR will fix Issue #13809.
With this commit the generation of imports for allOf compositions without discriminator has been disabled for all langauges except python & plain js. This is problematic/causes issues with some generated specs.
In this PR the new addImport method of the commit mentioned earlier is overriden in the TypeScriptAxiosClientCodegen.java to ensure previous behavior. If the change mentioned earlier is a problem for the other typescript generators as well the fix should probably be moved to the AbstractTypeScriptClientCodegen .
To validate the work use ./bin/generate-samples.sh bin/configs/typescript-axios-with-separate-models-and-api-inheritance.yaml once with and once without the fix and compare the files it generates.
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master(6.1.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.