Skip to content
GitLab

Spring request mapping mode

Merged Administrator requested to merge github/fork/cachescrubber/spring_request_mapping_mode into master

Created by: cachescrubber

requestMappingMode: Explicit configuration to control the location of the generated class level RequestMapping annotation

Since #10573, the @ RequestMapping has been moved from the controller to the generated api interface. This introduced incompatibilities in many scenarios, but specially when spring-cloud is used as a library. Unfortunately the fix from @MelleD (#13546) does not allow to override the default (for example when using interfaceOnly). This PR introduces a dedicated cli option to decide where the RequestMapping annotation should be placed.

` requestMappingMode Where to generate the class level @RequestMapping annotation. (Default: controller) iface - Generate the @RequestMapping annotation on the generated Api Interface. controller - Generate the @RequestMapping annotation on the generated Api Controller Implementation. none - Do not add a class level @RequestMapping annotation.

`

The default is controller, which is the same as before #10573. By explicitly using iface, the annotation could be added to the api interface.

Caused By

  • #10573

Based on

  • #13546

Fixes

PR checklist

  • [x ] Read the contribution guidelines.
  • [ x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ x] Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.