Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !1393

Fix regex generated in Ruby client

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/ggershoni/issue_1392-ruby_client_regex_fix into master Nov 06, 2018
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 13

Created by: ggershoni

Please see https://github.com/OpenAPITools/openapi-generator/issues/1392 for details

Note: I needed to update autotest-fsevent (0.2.13) to autotest-fsevent (0.2.14) in Gemfile.lock to make rspec work on macOS.

Would love your thoughts/advice @cliffano @zlx.

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

In AbstractRubyCodegen overloaded public String toRegularExpression(String pattern) from DefaultCodegen. Am not escaping the pattern (so no extra \ added) since the regex pattern is run inside regex delimiters already.

Added tests in both Java and Ruby client code.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ggershoni/issue_1392-ruby_client_regex_fix