Skip to content
GitLab

Initialize typeAliases in setOpenAPI

Merged Administrator requested to merge github/fork/tzeH/initialization-of-typeAliases into master

Created by: tzeH

The initialialization of the typeAlias field happens "on demand" in fromModel(...) but it's be better to do it in setOpenApi(...). This is because there are other methods such as fromOperation(...), which also depend on that initialization. Also, all the information that's necessary for typeAliases, is known in setOpenAPI.

This PR was requested as part of the review of https://github.com/OpenAPITools/openapi-generator/pull/13805#issuecomment-1318664950.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.