Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !14056

[cpp-qt-client] Fix warnings

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Martin Delille requested to merge github/fork/MartinDelille/cpp-qt-client-fix-warning into master 2 years ago
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 2

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @ravinikam @stkrwork @etherealjoy @muttleyxd

Checking approval status

Merged by William ChengWilliam Cheng 2 years ago (Nov 20, 2022 8:10am UTC) 2 years ago

Loading

Activity


  • William Cheng
    William Cheng @wing328 · 2 years ago
    Contributor

    can you please update the samples?

     void OauthCredentials::setVariables(QString tokenUrl, QString scope, QString clientId, QString clientSecret){
    @@ -206,7 +206,7 @@ void OauthPassword::link()
     
     void OauthPassword::unlink()
     {
    -    disconnect(this,0,0,0);
    +    disconnect(this, nullptr, nullptr, nullptr);
     }
     
     void OauthPassword::setVariables(QString tokenUrl, QString scope, QString clientId, QString clientSecret, QString username, QString password){
    Perform git status
    HEAD detached at pull/14056/merge
    Changes not staged for commit:
      (use "git add <file>..." to update what will be committed)
      (use "git restore <file>..." to discard changes in working directory)
    	modified:   samples/client/petstore/cpp-qt/client/PFXOauth.cpp
    
    no changes added to commit (use "git add" and/or "git commit -a")

    ref: https://github.com/OpenAPITools/openapi-generator/actions/runs/3490844364/jobs/5842865742

  • Martin Delille
    Martin Delille @MartinDelille · 2 years ago
    Author Contributor

    Sorry! Long time I didn't contribute and I just forgot! I would have check the issue in the CI anyway! :smile:

  • William Cheng added Client: C++ Enhancement: General labels 2 years ago

    added Client: C++ Enhancement: General labels

  • William Cheng
    William Cheng @wing328 · 2 years ago
    Contributor

    @MartinDelille No problem :) Always appreciate your contributions :thumbsup:

    Tested locally and the result is good:

    QDEBUG : UserApiTests::loginUserTest() "{\"code\":200,\"type\":\"unknown\",\"message\":\"logged in user session:1668931788895\"}"
    PASS   : UserApiTests::loginUserTest()
    PASS   : UserApiTests::logoutUserTest()
    QDEBUG : UserApiTests::updateUserTest() got a request body
    PASS   : UserApiTests::updateUserTest()
    PASS   : UserApiTests::cleanupTestCase()
    Totals: 10 passed, 0 failed, 0 skipped, 0 blacklisted, 121ms
    ********* Finished testing of UserApiTests *********
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time:  3.797 s
    [INFO] Finished at: 2022-11-20T00:09:49-08:00
    [INFO] ------------------------------------------------------------------------
  • Administrator
    Administrator @root · 2 years ago
    Contributor

    Merged by: wing328 at 2022-11-20 08:10:55 UTC

  • William Cheng closed 2 years ago

    closed

  • William Cheng changed milestone to %6.3.0 2 years ago

    changed milestone to %6.3.0

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
Lock merge request
Unlocked
participants
Reference:
Source branch: github/fork/MartinDelille/cpp-qt-client-fix-warning

Menu

Explore Projects Groups Snippets