Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !14125
An error occurred while fetching the assigned milestone of the selected merge_request.

[JAVA] [WebClient] Handle list of String special case in WebClient generator

  • Review changes

  • Download
  • Email patches
  • Plain diff
Administrator requested to merge github/fork/GavinWu1991/fix-7118 into master 2 years ago
  • Overview 2
  • Commits 4
  • Pipelines 1
  • Changes 5

Created by: GavinWu1991

When describing an operation that returns an array of strings, the openapi-generator for java-webclient generates an API returning the array of strings in a single string.

Recommended solution by Spring developers (see https://github.com/spring-projects/spring-framework/issues/22662 and https://docs.spring.io/spring/docs/current/spring-framework-reference/web-reactive.html#webflux-codecs-jackson) is to use a Mono for string arrays.

The PR contains the change that will generate the API client of the operation that returns an array of strings to Mono<List> instead of Flux.

Close: #7118

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Could not retrieve the pipeline status. For troubleshooting steps, read the documentation.

Approval is optional
The target branch master does not exist. Please restore it or use a different target branch.
Loading

Activity


  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: GavinWu1991

    @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: domizei385

    Please follow through with this. Trying to push reactive at my current customer and this issue has been causing a lot of push-back.

  • Administrator restored source branch github/fork/GavinWu1991/fix-7118 2 years ago

    restored source branch github/fork/GavinWu1991/fix-7118

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/GavinWu1991/fix-7118

Menu

Explore Projects Groups Snippets