Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !14278

Inline allOf parameters are always not required

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged devhl-labs requested to merge github/fork/devhl-labs/issue14163 into master Dec 17, 2022
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 29

Fixes https://github.com/OpenAPITools/openapi-generator/issues/14163

I tried writing a test instead of editing the samples such as below. The test succeeded with or without the change, which is strange because I can see the change is working as intended. openAPI.toString() returns the same thing before and after the change.

CSharpModelTest.java

    @Test
    public void assertAllOfIsRequired() {
        final OpenAPI openAPI = TestUtils.parseFlattenSpec("src/test/resources/3_0/csharp-netcore/issue_14163.yaml");
        CSharpNetCoreClientCodegen codegen = new CSharpNetCoreClientCodegen();
        codegen.setOpenAPI(openAPI);
        PathItem pathItem = openAPI.getPaths().get("/country");
        Operation operation = pathItem.getPost();
        String requiredParameter = (String) openAPI.getComponents().getSchemas().get("getCountry_request_allOf").getRequired().get(0);
        Assert.assertEquals(requiredParameter, "country");
    }

src/test/resources/3_0/csharp-netcore/issue_14163

openapi: 3.0.1
info:
  title: country
  version: 0.0.0
paths:
  "/country":
    post:
      operationId: getCountry
      requestBody:
        content:
          application/x-www-form-urlencoded:
            schema:
              allOf:
              - required:
                - country
                type: object
                properties:
                  country:
                    type: string
      responses:
        '200':
          description: OK
  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/devhl-labs/issue14163