Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !14358

[typescript-axios] single request param in factory

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/stropho/ts-axios-singlerequest-param into master 2 years ago
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: stropho

typescript-axios generator uses an option useSingleRequestParameter as mentioned in https://github.com/OpenAPITools/openapi-generator/blob/master/docs/generators/typescript-axios.md

However, this option is used only in generated classes. This PR reuse the same logic in api factories.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)

Loading
Loading

Activity


  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: macjohnny

    Review: Approved

    Thanks for your contribution!

  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Merged by: macjohnny at 2023-01-03 07:22:39 UTC

  • Administrator closed 2 years ago

    closed

  • Administrator added Client: TypeScript label 2 years ago

    added Client: TypeScript label

  • Administrator changed milestone to %6.3.0 2 years ago

    changed milestone to %6.3.0

  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: dbusacca

    I think this fix must be applied also to the generated "functional programming interface" and the "axios parameter creator".

    I've got an API with a parameter named "options" and it conflicts with the generated options?: AxiosRequestConfig parameter

  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: stropho

    I think this fix must be applied also to the generated "functional programming interface" and the "axios parameter creator".

    I don't have a strong opinion about this, but I guess you can always file an issue or possibly a PR

    I've got an API with a parameter named "options" and it conflicts with the generated options?: AxiosRequestConfig parameter

    A quick workaround would be to rename your parameter ;) Or a simple PR to use a more unique name such as axiosRequestConfig?: AxiosRequestConfig

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: firstcontributions/first-contributions!1090
Source branch: github/fork/stropho/ts-axios-singlerequest-param

Menu

Explore Projects Groups Snippets