Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !14447

[Go] [Client] Don't Explode Query Params

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/icubbon/goclient/explodeQueryParamFix into master 2 years ago
  • Overview 2
  • Commits 3
  • Pipelines 0
  • Changes 4

Created by: icubbon

Query params were incorrectly being exploded all the time, regardless of the setting in the spec. This was introduced with https://github.com/OpenAPITools/openapi-generator/pull/13909/files and addresses https://github.com/OpenAPITools/openapi-generator/issues/14089

I think there are a lot of different ways to fix this issue, but this was a minimal way to get a slice of query params to be comma separated.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @wing328

Approval is optional

Merged by William ChengWilliam Cheng 2 years ago (Jan 13, 2023 4:48pm UTC) 2 years ago

Loading

Activity


  • William Cheng
    William Cheng @wing328 · 2 years ago
    Contributor

    @icubbon thanks for the PR. Can you please PM me when you've time for a few quick questions on this PR?

    https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Merged by: wing328 at 2023-01-13 16:48:27 UTC

  • William Cheng closed 2 years ago

    closed

  • William Cheng changed milestone to %6.3.0 2 years ago

    changed milestone to %6.3.0

  • Administrator mentioned in issue #14089 2 years ago

    mentioned in issue #14089

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
6.3.0
6.3.0 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
2
2 participants
Administrator
William Cheng
Reference: OpenAPITools/openapi-generator!14447
Source branch: github/fork/icubbon/goclient/explodeQueryParamFix

Menu

Explore Projects Groups Snippets