Skip to content
GitLab

[Java] fix JsonTypeName import

Merged Oleh Kurpiak requested to merge github/fork/borsch/fix-jackson-imports into master

Conditional based implementation of https://github.com/OpenAPITools/openapi-generator/pull/12524

The main issue here is that generated model public class API01ListOfStuff extends ArrayList<API01AbstractStuff> doesn't have any properties that's why AbstractJavaCodegen#postProcessModelProperty doesn't invoked for this model. Since import of JsonTypeName is only model dependent and not model's property dependent, I've moved that import to fromModel method

Note: seems like there are few more imports which are only model dependent but are present in postProcessModelProperty. I'll clean-up them separately

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Java @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)
Java Spring @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09)