Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !14509
An error occurred while fetching the assigned milestone of the selected merge_request.

[Kotlin-Spring]: Dont't make readOnly properties nullable

  • Review changes

  • Download
  • Email patches
  • Plain diff
Administrator requested to merge github/fork/saschpe/kotlin-spring-readonly into master 2 years ago
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: saschpe

Resolves #14280 (closed)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Approval is optional

Merge details

  • 2 commits and 1 merge commit will be added to develop.
  • Source branch will not be deleted.
  • Mentions issue #14280 (closed)

Activity


  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: saschpe

    The CircleCI issue just needed an OAuth-reauth. Is there any way to retriever this job?

  • William Cheng
    William Cheng @wing328 · 2 years ago
    Contributor

    did a test to confirm the fix

    --- a/src/main/kotlin/org/openapitools/model/ExampleDTO.kt
    +++ b/src/main/kotlin/org/openapitools/model/ExampleDTO.kt
    @@ -25,7 +25,7 @@ data class ExampleDTO(
         @get:JsonProperty("id", required = true) val id: kotlin.String,
     
         @Schema(example = "null", required = true, readOnly = true, description = "")
    -    @get:JsonProperty("name", required = true) val name: kotlin.String? = null,
    +    @get:JsonProperty("name", required = true) val name: kotlin.String,
     
         @Schema(example = "null", description = "")
         @get:JsonProperty("surname") val surname: kotlin.String? = null
  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Merged by: wing328 at 2023-03-13 15:14:02 UTC

  • William Cheng closed 2 years ago

    closed

  • William Cheng
    William Cheng @wing328 · 2 years ago
    Contributor

    thanks for the PR, which has been merged.

  • William Cheng added Issue: Bug Server: Kotlin labels 2 years ago

    added Issue: Bug Server: Kotlin labels

  • William Cheng changed milestone to %6.5.0 2 years ago

    changed milestone to %6.5.0

  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: zaenk

    This way the generated schema can only be used for responses, but not for requests. readOnly should only affect the relevant scope, as per OpenAPI specification.

    type: object
    properties:
      id:
        # Returned by GET, not used in POST/PUT/PATCH
        type: integer
        readOnly: true

    https://swagger.io/docs/specification/data-models/data-types/#readonly-writeonly

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/saschpe/kotlin-spring-readonly

Menu

Explore Projects Groups Snippets