Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !14687
An error occurred while fetching the assigned milestone of the selected merge_request.

fix: Inline model schema's name is wrong

  • Review changes

  • Download
  • Email patches
  • Plain diff
Administrator requested to merge github/fork/davidediak/bug-inline-model-schemas-name-is-wrong into master 2 years ago
  • Overview 7
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: davidediak

Fixes #14688 (closed)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Loading
Loading

Activity


  • William Cheng
    William Cheng @wing328 · 2 years ago
    Contributor

    thanks for the fix, can you please share a minimal spec to reproduce the issue?

    i'm sure you're aware that the inline schema mapping can be customized: https://github.com/OpenAPITools/openapi-generator/blob/master/docs/customization.md#inline-schema-naming

  • William Cheng
    William Cheng @wing328 · 2 years ago
    Contributor

    Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

    Let me know if you need help fixing it.

    Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: davidediak

    Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

    Let me know if you need help fixing it.

    Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

    Sorry about that, should be ok now.

  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Created by: davidediak

    @wing328 I've added spec + how to reproduce in the related linked issue. Let me know if something is still missing.

  • William Cheng added Inline Schema Handling Issue: Bug labels 2 years ago

    added Inline Schema Handling Issue: Bug labels

  • William Cheng
    William Cheng @wing328 · 2 years ago
    Contributor

    tested locally to confirm the fix:

    --- a/.openapi-generator/FILES
    +++ b/.openapi-generator/FILES
    @@ -1,12 +1,11 @@
     .github/workflows/maven.yml
     .gitignore
    -.openapi-generator-ignore
     .travis.yml
     README.md
     api/openapi.yaml
     build.gradle
     build.sbt
    -docs/ApiV1CustomerIdGetRequest.md
    +docs/ApiV1CustomerIdPatchRequest.md
     docs/CustomerResponse.md
     docs/DefaultApi.md
     git_push.sh
    @@ -37,8 +36,6 @@ src/main/java/org/openapitools/client/auth/Authentication.java
     src/main/java/org/openapitools/client/auth/HttpBasicAuth.java
     src/main/java/org/openapitools/client/auth/HttpBearerAuth.java
     src/main/java/org/openapitools/client/model/AbstractOpenApiSchema.java
    -src/main/java/org/openapitools/client/model/ApiV1CustomerIdGetRequest.java
    +src/main/java/org/openapitools/client/model/ApiV1CustomerIdPatchRequest.java
     src/main/java/org/openapitools/client/model/CustomerResponse.java
    -src/test/java/org/openapitools/client/api/DefaultApiTest.java
    -src/test/java/org/openapitools/client/model/ApiV1CustomerIdGetRequestTest.java
    -src/test/java/org/openapitools/client/model/CustomerResponseTest.java
    +src/test/java/org/openapitools/client/model/ApiV1CustomerIdPatchRequestTest.java
  • William Cheng changed milestone to %6.4.0 2 years ago

    changed milestone to %6.4.0

  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Merged by: wing328 at 2023-02-17 16:10:21 UTC

  • William Cheng closed 2 years ago

    closed

  • William Cheng
    William Cheng @wing328 · 2 years ago
    Contributor

    @davidediak thanks for the fix, which has been merged.

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/davidediak/bug-inline-model-schemas-name-is-wrong

Menu

Explore Projects Groups Snippets