Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !14720

[JAVASCRIPT] Fix inconsistent validateJSON and validateJsonObject calls, breaking object validation.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/RInverid/validateJsonFix into master 2 years ago
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 17

Created by: RInverid

I ran into this issue when using OpenAPI's 'anyof' structure. This issue exists in every generated model, but apparently the received responses aren't validated by default. For anyOf this validation was done, and this issue was uncovered. No github issue was made, since the fix is so simple.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @CodeNinjai @frol @cliffano
Approval is optional

Merged by William ChengWilliam Cheng 2 years ago (Feb 16, 2023 2:22pm UTC) 2 years ago

Merge details

  • Changes merged into master with e7cf767b.
  • Deleted the source branch.

Activity


  • William Cheng added Client: JavaScript/Node.js Issue: Bug labels 2 years ago

    added Client: JavaScript/Node.js Issue: Bug labels

  • William Cheng changed milestone to %6.4.0 2 years ago

    changed milestone to %6.4.0

  • William Cheng
    William Cheng @wing328 · 2 years ago
    Contributor

    LGTM. Thanks for the PR.

  • Administrator
    Administrator @root · 2 years ago
    Author Contributor

    Merged by: wing328 at 2023-02-16 14:22:56 UTC

  • William Cheng closed 2 years ago

    closed

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
Client: JavaScript/Node.js Issue: Bug
2
Client: JavaScript/Node.js Issue: Bug
    Assign labels
  • Manage project labels

Milestone
6.4.0
6.4.0 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
2
2 participants
Administrator
William Cheng
Reference: OpenAPITools/openapi-generator!14720
Source branch: github/fork/RInverid/validateJsonFix

Menu

Explore Projects Groups Snippets