Created by: sjoubert
The {{declspec}} annotations were not consistently applied and were missing on some classes and free functions.
Side note: the declspec and defaultInclude config options are not officially documented for the cpp-pistache-server generator, but they work correctly (aside the missing annotations). Not sure if something needs to be done on that front.
My use case is that I'm building my server and APIs in a shared library and while trying to use the model classes in my tests couldn't link to it since some of the model symbols (to_json and from_json in my case) were not exported (I'm using declspec and defaultInclude for the classical use case of exporting symbols).
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
In case you are adding a new generator, run the following additional script : Commit all changed files../bin/utils/ensure-up-to-date.sh -
File the PR against the correct branch: master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. cc @ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd