This change removes a hard-coded import of com.fasterxml.jackson.annotation.JsonTypeName. The import was added in #8815, however a conditional import was later introduced in #11526. As a result, most generated code has a duplicate import, and if it's not a duplicate, it is not used.
I have a goal of removing @JsonTypeName from the generated code, as I believe it is unnecessary because the type names are always specified in the @JsonSubTypes annotations. This is one small step in the process, submitted as a separate PR as it affects so many sample files.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
In case you are adding a new generator, run the following additional script : Commit all changed files../bin/utils/ensure-up-to-date.sh -
File the PR against the correct branch: master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)