Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !14870

[v2] (RFC) Csharp netcore generator supports UnityWebRequest library

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/iBicha/feature/unity-support into master Mar 02, 2023
  • Overview 22
  • Commits 12
  • Pipelines 0
  • Changes 307

Created by: iBicha

This is a follow up to #13890, Closes #853 (closed)

#13890 was a great start (thank you for the work you've done!), but it sits in a private fork so was harder to work with

On top of it, a few changes has been made:

  • Remove irrelevant files to Unity (e.g. like project and solution files, these are Generated by Unity)
  • Added assembly definition files
  • Use NUnit (what Unity uses for tests)
  • Updated the readme with relevant information for Unity

I would love to see this more thoroughly tested, and validate it works well with different spec files, but from testing so far it seems good enough!

There's probably edge cases to deal with (IL2CPP, console support, etc), but perfect is the enemy of good! I hope we can have a foot in the door with this version and incrementally improve.

Also, I can't believe it's been almost 5 years since #853 (closed) !

Tagging the technical committee as per contribution guidelines @mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti

And @justonia @wing328 for visibility

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/iBicha/feature/unity-support