Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !1617

[core] Fix NPE for endpoints without responses

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/tomekc/crash_on_empty_responses into master Dec 05, 2018
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: tomekc

When generating Java client, generator was crashing with cryptic NPE. After debugging, it turned out, that one of the enpoints did not have 'responses' field defined, and there was no clue, what operation it was. The code looked like was supposed to deal with that situation, but by simple mistake it moved on and caused NPE.

Additional logging helped isolate the problem.

BTW: IntelliJ IDEA IDE suggested that change, so it is easy to spot it using static code analysis.

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tomekc/crash_on_empty_responses