Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !1841

[WIP] Fix allOf in inline model resolver

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed William Cheng requested to merge improve_flatten into master 6 years ago
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Found this bug while working on better allOf, anyOf, oneOf support: model instanceof Schema should be the last check, otherwise all other checks (eg.. ArraySchema) will be skipped.

Also deprecating fixStringModel as we shouldn't need it to remove double quote in enum example value

cc @OpenAPITools/generator-core-team

Approval is optional

Closed by (Jul 27, 2025 12:57pm UTC)

Merge details

  • The changes were not merged into master.

Activity


Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
4
Feature: Generator Feature: OAS 3.0 spec support Issue: Bug WIP
4
Feature: Generator Feature: OAS 3.0 spec support Issue: Bug WIP
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
William Cheng
Reference: OpenAPITools/openapi-generator!1841
Source branch: improve_flatten

Menu

Explore Projects Groups Snippets