Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !2112

Better handling of inline composed schemas in InlineModelResolver

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/rienafairefr/composed-inlinemodelresolver into master Feb 11, 2019
  • Overview 0
  • Commits 12
  • Pipelines 0
  • Changes 412

Created by: rienafairefr

PR checklist

  • Read the contribution guidelines.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.

Description of the PR

InlineModelResolver wasn't handling the composedschema case correctly or even at all, with this PR it can transform inline models like this:

ComposedModel:
  allOf:
  - $ref: '#/components/schemas/Model'
  - type: object
    properties:
      prop:
       type: string

into

ComposedModel:
  allOf:
  - $ref: '#/components/schemas/Model'
  - $ref: '#/components/schemas/ComposedModel_allOf'
ComposedModel_allOf:
  type: object
    properties:
      prop:
        type: string

this might help for handling correctly allOf/anyOf/oneOf, even in the case of the presence of inline model

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/rienafairefr/composed-inlinemodelresolver