Skip to content
GitLab

[rust-server] Changed query parameters to be url encoded

Merged Administrator requested to merge github/fork/joylabs/url_encode_query_params into master

Created by: Herrera93

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @frol @farcaller @bjgill

Description of the PR

Based on this issue the utf8_percent_encode doesn't percent encode + instead treats it as a space which is may cause a problem if the query parameters contain one. For example if we wanted to use a DateTime range in query parameters:

{base_path}{path}?start=2019-02-12T00:00:00+00:00&end=2019-02-13T15:00:00+00:00

These parameters may be decoded as:

start = 2019-02-12T00:00:00 00:00
end = 2019-02-13T15:00:00 00:00

To solve this I changed query parameters to be form-urlencoded using url::form_urlencoded based on what's done in rust client generator.