Skip to content
GitLab

C# refactor improvements: .NET Standard and .NET Core

Merged Jim Schubert requested to merge csharp-refactor-improvements into master

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Related to some discussion in #2014, this updates csharp-refactor to handle only .NET Standard and .NET Core. Doing this simplifies much of the logic differences between .NET Framework and PCL options available in the csharp generator, when compared to the .NET Standard and .NET Core options in the csharp-refactor generator.

As a result, this does change generator options and features by removing those which are not support in .NET Standard or .NET Core (e.g. no Fody property weaving).

The RestSharp dependency has a hard limit on netstandard2.0. This works for both .NET Standard and .NET Core 2.0, and while it's possible that the library will work in one of the .NET Standard 1.x configurations, we will log a message explaining that the only supported configuration for the built-in template is .NET Standard 2.0. The .NET Standard 1.x framework options exist to enable developers to extend the generator with their own custom templates.