Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !2283
An error occurred while fetching the assigned milestone of the selected merge_request.

Apply `GIN_MODE=release` for the Dockerfile of `go-gin-server`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/kemokemo/apply_gin_mode into master 6 years ago
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 8

Created by: kemokemo

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

In order to run as Release mode, the gin-gonic/gin needs the environment variable GIN_MODE=release. I think that it is better for this environment variable to be applied to the Dockerfile generated by the go-gin-server generator.

@antihax (2017/11) @bvwells (2017/12) @grokify (2018/07) Would you please review this PR? Thank you so much! :smiley:

Compare
  • master (base)

and
  • latest version
    eb2d4092
    3 commits, 2 years ago

8 files
+ 99
- 1

    Preferences

    File browser
    Compare changes
modules/…/…/…/‎…/go-gin-server‎
Dockerfil‎e.mustache‎ +1 -0
sam‎ples‎
openapi3/server/…‎/go-gin-api-server‎
a‎pi‎
openap‎i.yaml‎ +33 -1
g‎o‎
model_enu‎m_test_.go‎ +6 -0
model_outer_enum‎_default_value.go‎ +19 -0
model_outer_e‎num_integer.go‎ +19 -0
model_outer_enum_int‎eger_default_value.go‎ +19 -0
Docke‎rfile‎ +1 -0
server/petstore/‎go-gin-api-server‎
Docke‎rfile‎ +1 -0
modules/openapi-generator/src/main/resources/go-gin-server/Dockerfile.mustache
+ 1
- 0
  • View file @ eb2d4092

  • Edit in single-file editor

  • Open in Web IDE


@@ -9,6 +9,7 @@ RUN go get -d -v ./...
RUN go build -a -installsuffix cgo -o {{packageName}} .
FROM scratch AS runtime
ENV GIN_MODE=release
COPY --from=build /go/src/{{packageName}} ./
EXPOSE 8080/tcp
ENTRYPOINT ["./{{packageName}}"]
samples/openapi3/server/petstore/go-gin-api-server/api/openapi.yaml
+ 33
- 1
  • View file @ eb2d4092

  • Edit in single-file editor

  • Open in Web IDE


@@ -81,6 +81,9 @@ paths:
summary: Update an existing pet
tags:
- pet
servers:
- url: http://petstore.swagger.io/v2
- url: http://path-server-test.petstore.local/v2
/pet/findByStatus:
get:
description: Multiple status values can be provided with comma separated strings
@@ -1462,6 +1465,7 @@ components:
format: date-time
type: string
uuid:
example: 72f98069-206d-4f12-9f12-3d1e525a8e84
format: uuid
type: string
password:
@@ -1518,6 +1522,12 @@ components:
type: number
outerEnum:
$ref: '#/components/schemas/OuterEnum'
outerEnumInteger:
$ref: '#/components/schemas/OuterEnumInteger'
outerEnumDefaultValue:
$ref: '#/components/schemas/OuterEnumDefaultValue'
outerEnumIntegerDefaultValue:
$ref: '#/components/schemas/OuterEnumIntegerDefaultValue'
required:
- enum_string_required
type: object
@@ -1678,10 +1688,32 @@ components:
- approved
- delivered
type: string
OuterEnumInteger:
enum:
- 0
- 1
- 2
format: int32
type: integer
OuterEnumDefaultValue:
default: placed
enum:
- placed
- approved
- delivered
type: string
OuterEnumIntegerDefaultValue:
default: 0
enum:
- 0
- 1
- 2
format: int32
type: integer
OuterComposite:
example:
my_string: my_string
my_number: 0.80082819046101150206595775671303272247314453125
my_number: 0.8008281904610115
my_boolean: true
properties:
my_number:
samples/openapi3/server/petstore/go-gin-api-server/go/model_enum_test_.go
+ 6
- 0
  • View file @ eb2d4092

  • Edit in single-file editor

  • Open in Web IDE


@@ -20,4 +20,10 @@ type EnumTest struct {
EnumNumber float64 `json:"enum_number,omitempty"`
OuterEnum OuterEnum `json:"outerEnum,omitempty"`
OuterEnumInteger OuterEnumInteger `json:"outerEnumInteger,omitempty"`
OuterEnumDefaultValue OuterEnumDefaultValue `json:"outerEnumDefaultValue,omitempty"`
OuterEnumIntegerDefaultValue OuterEnumIntegerDefaultValue `json:"outerEnumIntegerDefaultValue,omitempty"`
}
samples/openapi3/server/petstore/go-gin-api-server/go/model_outer_enum_default_value.go 0 → 100644
+ 19
- 0
  • View file @ eb2d4092

  • Edit in single-file editor

  • Open in Web IDE

/*
* OpenAPI Petstore
*
* This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
*
* API version: 1.0.0
* Generated by: OpenAPI Generator (https://openapi-generator.tech)
*/
package petstoreserver
type OuterEnumDefaultValue string
// List of OuterEnumDefaultValue
const (
PLACED OuterEnumDefaultValue = "placed"
APPROVED OuterEnumDefaultValue = "approved"
DELIVERED OuterEnumDefaultValue = "delivered"
)
samples/openapi3/server/petstore/go-gin-api-server/go/model_outer_enum_integer.go 0 → 100644
+ 19
- 0
  • View file @ eb2d4092

  • Edit in single-file editor

  • Open in Web IDE

/*
* OpenAPI Petstore
*
* This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
*
* API version: 1.0.0
* Generated by: OpenAPI Generator (https://openapi-generator.tech)
*/
package petstoreserver
type OuterEnumInteger int32
// List of OuterEnumInteger
const (
_0 OuterEnumInteger = "0"
_1 OuterEnumInteger = "1"
_2 OuterEnumInteger = "2"
)
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/kemokemo/apply_gin_mode

Menu

Explore Projects Groups Snippets