Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !2301

[R] Handling null values for optional params while building the model json object

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/Ramanth/patch-2 into master Mar 05, 2019
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: Ramanth

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Error when optional parameters are not given for the model object

When generating the json of a model using the toJSONString() we encounter an error when we dont pass the optional paramameters (which are of non-primitive type)

Below changes handles the listContainer type optional parameters by replacing them with "null". so that it will be ignored by the endpoint.

Please make necessary changes if required. @wing328 , please look into and take required action.

Example to test: please consider a model which is hanving an example as below

{
	"key1" : "value1",
	"key2" : [  {"k1" : "v1"},
                    {"k2" : "v2"} ],
	"key3" : {  "k3" : "v3",
                     "k4" : "v4"
         	      }
}

In the above example consider key2 as an optional parameter and of type listContainer (i.e, array). Which is throwing an error when we dont provide the value for key2 while generating the model object. Please review this changes and make required changes to handle such scenarios.

Thanks, Ramanth.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Ramanth/patch-2