Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !2437

[Java][Spring] Fix template for reactive implementation with `interfaceOnly` parameter

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/logarithm/fix-spring-reactive into master Mar 18, 2019
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: logarithm

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language (Java technical committee: @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger).

Description of the PR

If for java spring-boot template generator we combine reactive and interfaceOnly properties then openapi generator generates incorrect code.

Example without fix:

default Mono<ResponseEntity<ResponseWrapper>> _methodName(@ApiParam(value = ""  )  @Valid @RequestBody Mono<RequestWrapper> requestWrapper, ServerWebExchange exchange) {
    return methodName(requestWrapper);
}

// Override this method
default Mono<ResponseEntity<ResponseWrapper>> methodName(RequestWrapper requestWrapper, ServerWebExchange exchange) {
    Mono<Void> result = Mono.empty();
    exchange.getResponse().setStatusCode(HttpStatus.NOT_IMPLEMENTED);
    for (MediaType mediaType : exchange.getRequest().getHeaders().getAccept()) {
        if (mediaType.isCompatibleWith(MediaType.valueOf("application/json"))) {
            result = ApiUtil.getExampleResponse(exchange, "");
            break;
        }
    }
    return result.then(Mono.empty());
}

There are multiple problems:

  1. Interface method passes incorrect parameter list to delegate.
  2. First parameter type of delegate method is incorrect.

After template fix applied:

default Mono<ResponseEntity<ResponseWrapper>> _methodName(@ApiParam(value = ""  )  @Valid @RequestBody Mono<RequestWrapper> requestWrapper, ServerWebExchange exchange) {
    return methodName(requestWrapper, exchange);
}

// Override this method
default Mono<ResponseEntity<ResponseWrapper>> methodName(Mono<RequestWrapper> requestWrapper, ServerWebExchange exchange) {
    Mono<Void> result = Mono.empty();
    exchange.getResponse().setStatusCode(HttpStatus.NOT_IMPLEMENTED);
    for (MediaType mediaType : exchange.getRequest().getHeaders().getAccept()) {
        if (mediaType.isCompatibleWith(MediaType.valueOf("application/json"))) {
            result = ApiUtil.getExampleResponse(exchange, "");
            break;
        }
    }
    return result.then(Mono.empty());
}
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/logarithm/fix-spring-reactive