Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !2487

[Kotlin][Spring] optional types for required=false without defaultValue

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/markus-wa/kotlin-spring-optional-params into master Mar 23, 2019
  • Overview 0
  • Commits 4
  • Pipelines 0
  • Changes 18

Created by: markus-wa

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

cc: @jimschubert (2017/09) @dr4ke616 (2018/08)

Description of the PR

This fixes a regression introduced (presumeably) by #1107 / #1106 (closed)

The parameter types should only be non-nullable if they are either required or have a default value. Since defaultValue is "null" (a string) by default, mustache treats it as a value (not-false or unset) the {{#defaultValue}}bla{{/defaultValue}} branch was alway hit, never {{^defaultValue}}.....

This change follows a similar pattern of the C# generator which uses the helper property isNullable for this instead.

It also fixes Failed to convert value of type 'java.lang.String' to required type 'java.lang.Integer'; nested exception is java.lang.NumberFormatException: For input string: "null" if the optional parameter isn't provided in the request by removing the defaultValue parameter if it's "null".

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/markus-wa/kotlin-spring-optional-params