Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !2494

[go] Generate inline enum models and prefix all enums

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/fantavlik/go-fix-enums into master Mar 24, 2019
  • Overview 0
  • Commits 8
  • Pipelines 0
  • Changes 20

Created by: fantavlik

PR checklist

  • [ ✓ ] Read the contribution guidelines.
  • [ ✓ ] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [ ✓ ] Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • [ ✓ ] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

CC: @antihax @bvwells @grokify @kemokemo

This aims to address the following issues: https://github.com/OpenAPITools/openapi-generator/issues/535 (also see related closed PR: https://github.com/OpenAPITools/openapi-generator/pull/542) https://github.com/OpenAPITools/openapi-generator/issues/2050 https://github.com/OpenAPITools/openapi-generator/issues/2360

Description of the PR

There are four main aspects:

  1. Enums that are defined inline were not being generated (see https://github.com/OpenAPITools/openapi-generator/issues/2360 for an example), this PR follows similar logic to the typescript-fetch generation template to remedy this: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/typescript-fetch/modelGeneric.mustache#L92-L109
  2. Enums names often result in namespace collisions within the package being generated (see https://github.com/OpenAPITools/openapi-generator/issues/535), prefixes have been added to help prevent this for most cases.
  3. Numeric enum values were improperly being quoted, now only strings are.
  4. Numeric enum names were not properly escaping plus/minus signs and decimal points e.g. to differentiate between -1 and 1 or 1.1 and 11
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/fantavlik/go-fix-enums